Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clearly indicate that userSuppliedSearchTerm variable represents parameter for the query (Fixes #20361) #21256

Merged
merged 1 commit into from
Jun 16, 2020
Merged

Clearly indicate that userSuppliedSearchTerm variable represents parameter for the query (Fixes #20361) #21256

merged 1 commit into from
Jun 16, 2020

Conversation

manvydasu
Copy link
Contributor

@manvydasu manvydasu commented Jun 14, 2020 •
edited
Loading

Fixes #20361

@manvydasu manvydasu changed the title Clearly indicate that userSuppliedSearchTerm variable represents parameter for the query (Fixes #20361) Clearly indicate that userSuppliedSearchTerm variable represents parameter for the query (Fixes https://github.com/dotnet/efcore/issues/20361) Jun 14, 2020
@manvydasu manvydasu changed the title Clearly indicate that userSuppliedSearchTerm variable represents parameter for the query (Fixes https://github.com/dotnet/efcore/issues/20361) Clearly indicate that userSuppliedSearchTerm variable represents parameter for the query (Fixes #20361) Jun 14, 2020
smitpatel
smitpatel requested changes Jun 14, 2020
View reviewed changes
Copy link
Member

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not fix the issue.

@manvydasu
Copy link
Contributor Author

@smitpatel
I've updted the PR. The searchTerm '.NET' is used in the docs here https://docs.microsoft.com/en-us/ef/core/querying/raw-sql , so I thought that it might be a good fit.

@manvydasu manvydasu requested a review from smitpatel June 16, 2020 18:13
@smitpatel smitpatel merged commit 8d06c61 into dotnet:master Jun 16, 2020
@ajcvickers ajcvickers mentioned this pull request Jun 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees

@smitpatel smitpatel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Give example of what userSuppliedSearchTerm can be.
2 participants
@manvydasu @smitpatel