Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test ordering issue #21342

Merged
merged 1 commit into from
Jun 19, 2020
Merged

Fix test ordering issue #21342

merged 1 commit into from
Jun 19, 2020

Conversation

roji
Copy link
Member

@roji roji commented Jun 19, 2020

Fixes #21341

@roji roji requested review from smitpatel and maumar June 19, 2020 20:18
smitpatel
smitpatel approved these changes Jun 19, 2020
View reviewed changes
Copy link
Member

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as build passes.

@roji
Copy link
Member Author

roji commented Jun 19, 2020

As long as build passes.

That is implicit information in any review approval :)

@roji roji merged commit 7ba2f47 into master Jun 19, 2020
@roji roji deleted the TestOrdering branch June 19, 2020 21:34
@ajcvickers ajcvickers mentioned this pull request Jun 25, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

@maumar maumar Awaiting requested review from maumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single_non_scalar_projection_after_skip_uses_join failing because of missing ORDER BY
2 participants
@roji @smitpatel