Query: Make it easy to map built-in functions #21391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
smit/nowweneedthatflag
branch
from
fcc947b
to
8568a8a
Compare
src/EFCore.SqlServer/Metadata/Conventions/SqlServerDbFunctionConvention.cs
Outdated
Show resolved
Hide resolved
src/EFCore.SqlServer/Metadata/Conventions/SqlServerDbFunctionConvention.cs
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Jun 23, 2020
Resolves #17268 - Introduces new API `IsBuiltIn` on DbFunctionBuilder which marks the function as built-in and we translate it accordingly. - Add `DbFunctionAttribute.IsBuiltIn` and convention to set the flag appropriately.
smitpatel
force-pushed
the
smit/nowweneedthatflag
branch
from
8568a8a
to
d65d0ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #17268
IsBuiltInon DbFunctionBuilder which marks the function as built-in and we translate it accordingly.DbFunctionAttribute.IsBuiltInand convention to set the flag appropriately.