Allow DbContextFactory to use a pool #21431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Jun 28, 2020
|
You'd also need to collapse them into one type and get rid of the interface to avoid boxing |
ajcvickers
commented
Jun 28, 2020
src/EFCore/Extensions/EntityFrameworkServiceCollectionExtensions.cs
Outdated
Show resolved
Hide resolved
ajcvickers
force-pushed
the
WestCountryPool0613
branch
from
3a9070b
to
1dafcf0
Compare
|
@AndriySvyryd New version up. |
AndriySvyryd
approved these changes
Jun 28, 2020
Fixes #21247 Refactors the context pooling code to create a cleaner responsibility of services. Has the same restrictions as regular pooling since the context instances are reused.
ajcvickers
force-pushed
the
WestCountryPool0613
branch
from
1dafcf0
to
d7b9414
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21247
Refactors the context pooling code to create a cleaner responsibility of services.
Has the same restrictions as regular pooling since the context instances are reused.