Query: Put client method to fetch join entity after filtered include … #21517
Conversation
| @@ -710,10 +710,10 @@ public virtual Task Filtered_include_on_skip_navigation_then_filtered_include_on | |||
| { | |||
| return AssertQuery( | |||
| async, | |||
| ss => ss.Set<EntityTwo>().Include(e => e.OneSkip.Where(i => i.Id > 15)).ThenInclude(e => e.Collection.Where(i => i.Id < 5)), | |||
| ss => ss.Set<EntityThree>().Include(e => e.OneSkipPayloadFull.Where(i => i.Id > 15)).ThenInclude(e => e.Collection.Where(i => i.Id < 5)), | |||
There was a problem hiding this comment.
Had to change this test since, it was bringing entity two from 2 different query parts where state manager was fixing it up in tracked query and that would make result of filtered include "incorrect"
|
Hello @smitpatel! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
@msftbot require 1 sign-off |
|
Hello @smitpatel! I think you told me that you expect at least 1 approvals before I perform the merge, but I am not confident that I have understood you correctly. Please try rephrasing your instruction to me. |
|
@msftbot require 1 approval |
|
Hello @smitpatel! Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:
If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you". |
…expression Part of #19003 The issue was that we put the client method to fetch join entity directly after navigation hence the methods on filtered include threw client eval error. Fix: We generate a join with both join/target entity and apply all filtered incldue expression by remapping them. At the end we apply client projection selector
smitpatel
force-pushed
the
smit/filterincludewithjoinentities
branch
from
a822d04
to
b2fb18f
Compare
ghost
merged commit 
…expression
Part of #19003
The issue was that we put the client method to fetch join entity directly after navigation hence the methods on filtered include threw client eval error.
Fix: We generate a join with both join/target entity and apply all filtered incldue expression by remapping them. At the end we apply client projection selector