Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include key values in the update topological sort #21556

Merged
1 commit merged into from
Jul 10, 2020
Merged

Include key values in the update topological sort #21556

1 commit merged into from
Jul 10, 2020

Conversation

AndriySvyryd
Copy link
Member

Don't use entry sharing for entities with the same AK values
Only remove the entry with duplicate key value from the identity map if it's still there

Fixes #20870

@ghost
Copy link

ghost commented Jul 8, 2020

Hello @AndriySvyryd!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@AndriySvyryd
Copy link
Member Author

@msftbot require 1 approval

@ghost
Copy link

ghost commented Jul 8, 2020

Hello @AndriySvyryd!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it has at least 1 approval

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

Don't use entry sharing for entities with the same AK values
Only remove the entry with duplicate key value from the identity map if it's still there

Fixes #20870
@ghost ghost merged commit 78646d2 into master Jul 10, 2020
@ghost ghost deleted the Issue20870 branch July 10, 2020 19:39
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Topological sort should consider unique constraints for ordering
2 participants