Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test: Assert all the SQL #21574

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Test: Assert all the SQL #21574

merged 1 commit into from
Jul 9, 2020

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Jul 9, 2020

Makes AssertSql() assert that no SQL was generated (used to no-op)

@bricelam bricelam requested review from smitpatel and maumar July 9, 2020 22:38
smitpatel
smitpatel approved these changes Jul 9, 2020
View reviewed changes
Copy link
Member

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how you found it lol

@bricelam
Copy link
Contributor Author

bricelam commented Jul 9, 2020

lol, @roji added some in Migrations to assert that no SQL was generated, but they didn't start failing when I thought they would.

@bricelam
Test: Assert all the SQL
321d16c 
Makes `AssertSql()` assert that no SQL was generated (used to no-op)
@bricelam bricelam merged commit 321d16c into dotnet:master Jul 9, 2020
@bricelam bricelam deleted the assert branch July 9, 2020 23:41
@roji
Copy link
Member

roji commented Jul 10, 2020

Love those negative tests

@ajcvickers ajcvickers mentioned this pull request Jul 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

@maumar maumar Awaiting requested review from maumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bricelam @roji @smitpatel