Deprecate defining query at Core level #21622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Jul 14, 2020
smitpatel
reviewed
Jul 14, 2020
test/EFCore.InMemory.FunctionalTests/Query/InheritanceQueryInMemoryFixture.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Jul 14, 2020
| .ToQuery( | ||
| () => context.Set<Bird>() | ||
| .Select(b => MaterializeView(b))); | ||
| InMemoryEntityTypeBuilderExtensions.ToQuery( |
There was a problem hiding this comment.
ToQuery directly on entity type builder does not work?
There was a problem hiding this comment.
It's ambiguous until the obsoleted method is removed
There was a problem hiding this comment.
Let's discuss in design meeting.
smitpatel
approved these changes
Jul 14, 2020
|
Hello @AndriySvyryd! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
|
@AndriySvyryd @smitpatel Should we put this in preview 8? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18903