Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FindEntityType(Type) as appropriate #21639

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Use FindEntityType(Type) as appropriate #21639

merged 1 commit into from
Jul 15, 2020

Conversation

smitpatel
Copy link
Member

  • Make FindEntityType(Type) return null for shared type entity type
  • Add IModel.IsShared(Type) API
  • Flow IEntityType info in places when availble rather than doing Type based loopup

Part of #9914

@smitpatel smitpatel requested a review from a team July 15, 2020 16:25
@smitpatel
Use FindEntityType(Type) as appropriate
0aca681 
- Make FindEntityType(Type) return null for shared type entity type
- Add IModel.IsShared(Type) API
- Flow IEntityType info in places when availble rather than doing Type based loopup

Part of #9914
@smitpatel
Copy link
Member Author

Will perform command line build locally and merge.

@smitpatel
Copy link
Member Author

yay! Checks are back!

@ghost
Copy link

ghost commented Jul 15, 2020

Hello @smitpatel!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@smitpatel smitpatel changed the base branch from master to release/5.0-preview8 July 15, 2020 19:12
@smitpatel
Copy link
Member Author

Retargeting to preview8

@ghost
Copy link

ghost commented Jul 15, 2020

Apologies, while this PR appears ready to be merged, it looks like release/5.0-preview8 is a protected branch and I have not been granted permission to perform the merge.

@smitpatel smitpatel merged commit 1e6104a into release/5.0-preview8 Jul 15, 2020
@smitpatel smitpatel deleted the smit/implicitM2M branch July 15, 2020 21:25
@ajcvickers ajcvickers mentioned this pull request Jul 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

Assignees
No one assigned
Labels
auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smitpatel @ajcvickers @AndriySvyryd