Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure command parameters as nullable for optional dependents in table splitting #21724

Merged
2 commits merged into from
Jul 23, 2020
Merged

Configure command parameters as nullable for optional dependents in table splitting #21724

2 commits merged into from
Jul 23, 2020

Conversation

AndriySvyryd
Copy link
Member

Fixes #21612

@AndriySvyryd AndriySvyryd requested a review from a team July 22, 2020 00:46
@ghost
Copy link

ghost commented Jul 22, 2020

Hello @AndriySvyryd!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@AndriySvyryd
Copy link
Member Author

@msftbot Require 1 sign off

@ghost
Copy link

ghost commented Jul 22, 2020

Hello @AndriySvyryd!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I'll only merge this pull request if it has at least 1 approval

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@microsoft-github-updates microsoft-github-updates bot changed the base branch from master to main July 23, 2020 04:35
smitpatel
smitpatel approved these changes Jul 23, 2020
View reviewed changes
src/EFCore.Relational/Storage/Internal/TypeMappedPropertyRelationalParameter.cs Show resolved Hide resolved
src/EFCore.Relational/Storage/TypeMaterializationInfo.cs
public TypeMaterializationInfo(
[NotNull] Type modelClrType,
[CanBeNull] IProperty property,
[NotNull] RelationalTypeMapping mapping = null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NotNull attribute and default value null?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If only there was some feature in C# that would show an error when a null is assigned to a non-nullable reference type...

test/EFCore.SqlServer.FunctionalTests/DataAnnotationSqlServerTest.cs Show resolved Hide resolved
src/EFCore.Relational/Storage/TypeMaterializationInfo.cs Show resolved Hide resolved
@ghost ghost merged commit ae920c7 into main Jul 23, 2020
@ghost ghost deleted the Issue21612 branch July 23, 2020 22:18
@smitpatel
Copy link
Member

I was late! 😞

@ajcvickers
Copy link
Member

@smitpatel Don't think you can compete against the robots and win! Bad mistake.

@ajcvickers ajcvickers mentioned this pull request Jul 30, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Table Splitting Discriminator property should be nullable by default
3 participants
@AndriySvyryd @smitpatel @ajcvickers