Query: Disallow FromSql/TVF with TPT #21725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -130,6 +131,13 @@ public override void Validate(IModel model, IDiagnosticsLogger<DbLoggerCategory. | |||
| throw new InvalidOperationException(RelationalStrings.DbFunctionInvalidReturnEntityType( | |||
| dbFunction.ModelName, dbFunction.ReturnType.ShortDisplayName(), elementType.ShortDisplayName())); | |||
| } | |||
|
|
|||
| if (entityType.BaseType != null || entityType.GetDerivedTypes().Any() | |||
| && entityType.GetDiscriminatorProperty() == null) | |||
There was a problem hiding this comment.
I'm not sure that we support TPH, do we have any tests?
There was a problem hiding this comment.
Probably not tests but it just works due to design.
AndriySvyryd
approved these changes
Jul 22, 2020
- Throw exception when using FromSql* methods - Throw if a TVF is mapped to TPT - Throw if construction of SelectExpression with custom TableExpression is done when TPT Resolves #21508
|
Hello @smitpatel! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #21508