Query: Disallow FromSql on owner when owned navigation is mapped to s…

[smitpatel]

…ame table

Resolves #21769

It would still work if owned navigation data is not accessed. Though keep in mind that selecting entity will bring owned data too due to auto include

[ghost]

Hello @smitpatel!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[AndriySvyryd]

Perhaps we should also block auto-included navs to types that are sharing the same table

[smitpatel]

Perhaps we should also block auto-included navs to types that are sharing the same table

For FromSql scenario? Non-owned? AutoInclude API navs?

[AndriySvyryd]

For FromSql scenario? Non-owned? AutoInclude API navs?

Yeeees

[smitpatel]

That is ok. Auto-include is just one cause but otherwise any navigation usage causes us to get the other query source. For non-owned scenario, the other query source forms own query root and can have own mapping used.
As one of the options was here also in the case that we can generate join to actual table to get data. For aggregate it makes less sense to pick from 2 different sources. For non-aggregate, it would be bit too much restriction.

There is also #14525

[AndriySvyryd]

@smitpatel I understand that it's possible, it just seems ambiguous as to what shape FromSql expects when there are auto-includes with table-splitting. Perhaps this (and the owned case) can be overridden by an explicit Include.

needs-design?

[smitpatel]

Filed #21781