Merge preview8 into main #21788
Closed
Merge preview8 into main #21788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Check that DbConnection is Open before attempting to rollback and/or release a savepoint, and swallow (log) any exceptions that bubble up from those operations. * Call close on IRelationalConnection after releasing savepoint to make sure open/close are balanced. Closes #21340 (cherry picked from commit 385291f)
|
Hello @roji! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
roji
force-pushed
the
MergePreview8IntoMain
branch
2 times, most recently
from
c1561aa
to
fd67ebe
Compare
smitpatel
reviewed
Jul 25, 2020
| @@ -1,3 +1,4 @@ | |||
|
|
|||
There was a problem hiding this comment.
Good catch. Submitted #21789 to fix this in release/5.0-preview8 first (please approve), after that's merged I'll redo this PR.
There was a problem hiding this comment.
Not a functional impact. Just make it part of merge commit and it is fine.
roji
force-pushed
the
MergePreview8IntoMain
branch
from
fd67ebe
to
f941f9d
Compare
|
Already been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge preview8 into main after #21785