Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IConventionEntityTypeBuilder.HasSkipNavigation that takes an inverse #21850

Merged
1 commit merged into from
Jul 30, 2020

Conversation

AndriySvyryd
Copy link
Member

Fixes #21486

@AndriySvyryd AndriySvyryd requested a review from a team July 30, 2020 00:46
@ghost
Copy link

ghost commented Jul 30, 2020

Hello @AndriySvyryd!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[NotNull] EntityType targetEntityType,
MemberIdentity inverseNavigation,
ConfigurationSource configurationSource,
bool? collections = null,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can collection behavior of both skip navigation be different?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also collections vs collection in other methods

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. I think that would be less likely, so it would be ok to make two calls in that case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also collections vs collection in other methods

What do you mean? Other methods only have one navigation

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit odd, that method name is singular, takes 2 member identity and plural parameter. It will show up in API review!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit odd, that method name is singular, takes 2 member identity and plural parameter. It will show up in API review!

It only create one navigation on this entity type and that's what it returns

@ghost ghost merged commit 634948d into main Jul 30, 2020
@ghost ghost deleted the Issue21486 branch July 30, 2020 02:22
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add IConventionEntityTypeBuilder.HasManyToManyRelationship
2 participants