Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FreeText tests #21922

Merged
1 commit merged into from
Aug 3, 2020
Merged

Fix FreeText tests #21922

1 commit merged into from
Aug 3, 2020

Conversation

smitpatel
Copy link
Member

Resolves #18199

@smitpatel smitpatel requested a review from a team August 3, 2020 21:27
@ghost
Copy link

ghost commented Aug 3, 2020

Hello @smitpatel!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@@ -225,15 +227,15 @@ public void FreeText_through_navigation_with_language_terms()
c => EF.Functions.FreeText(c.Manager.Title, "President", 1033)
&& EF.Functions.FreeText(c.Title, "Inside", 1031)
&& c.FirstName.Contains("Lau"))
.LastOrDefault();
.FirstOrDefault();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reckon there is only one matching row in the table, but perhaps we should add orderby instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the operator irrelevant here?
What we are testing is translate of FreeText function. So I just added a mix rather than using LastOrDefault everywhere.

@@ -423,16 +425,16 @@ public void Contains_through_navigation()
.Where(
c => EF.Functions.Contains(c.Manager.Title, "President")
&& EF.Functions.Contains(c.Title, "\"Ins*\""))
.LastOrDefault();
.FirstOrDefault();

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@ghost ghost merged commit 180283d into main Aug 3, 2020
@ghost ghost deleted the smit/freetext branch August 3, 2020 22:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FreeText_through_navigation is broken
2 participants