-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query: Add logging #21924
Query: Add logging #21924
Conversation
test/EFCore.SqlServer.FunctionalTests/Query/QueryLoggingSqlServerTest.cs
Outdated
Show resolved
Hide resolved
Part of #17498 Added messages - Starting query compilation - Navigation included - Skip/Take without order by (infra is in core but providers use to generate the warning) - First without order by or predicate (infra is in core but providers use to generate the warning) Removed messages - Include ignored (they get removed due to automatic pruning based on expression tree visitation - Obsolete exception with aggregate operator in relational. We logged that when doing client eval of aggregate operation - Optimized query model - there is no more optimization phase. Other fixes - Don't log parameter values in Cosmos when sensitive data logging is not enabled.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hello @smitpatel! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:
These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check. Give feedback on thisFrom the bot dev teamWe've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments. Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin. |
Part of #17498
Added messages
Removed messages
Other fixes