Add end to end test for shared type entity type #21948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maumar
approved these changes
Aug 6, 2020
AndriySvyryd
approved these changes
Aug 6, 2020
|
Hello @smitpatel! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit
smitpatel
commented
Aug 6, 2020
|
|
||
| entity["Payload"] = "AlreadyUpdated"; | ||
|
|
||
| context.Set<Dictionary<string, object>>("JoinOneToThreePayloadFullShared").Update(entity); |
There was a problem hiding this comment.
@ajcvickers - Why was this necessary to update the entity on database?
There was a problem hiding this comment.
Did this fail for the changing tracking proxy test only? If so, it looks like it's because changing an indexer property is not sending a notification to the state manager. This is a bug. (Even if it turns out to be impossible, it should at least be a warning when using change tracking prioxies.)
There was a problem hiding this comment.
Yes, only failed for changetracking proxies
This was referenced Aug 6, 2020
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #19979
Also verify return type of DbSet with CLR type of EntityType
Resolves #21937