API review changes #21960
Merged
API review changes #21960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #20409
|
Hello @smitpatel! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
AndriySvyryd
reviewed
Aug 6, 2020
| @@ -62,13 +62,14 @@ private enum Id | |||
| RowLimitingOperationWithoutOrderByWarning, | |||
| FirstWithoutOrderByAndFilterWarning, | |||
| Obsolete_QueryModelOptimized, | |||
| NavigationIncluded, | |||
| Obsolete_NavigationIncluded, | |||
There was a problem hiding this comment.
Rename the other unused members
There was a problem hiding this comment.
At least in query there are no unused members. Did you have something specific in mind?
AndriySvyryd
approved these changes
Aug 6, 2020
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #20409