Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API review changes #22037

Merged
2 commits merged into from
Aug 12, 2020
Merged

API review changes #22037

2 commits merged into from
Aug 12, 2020

Conversation

ajcvickers
Copy link
Member

Part of #20409

  • Use FullName instead of DisplayName in the in-memory database
  • Remove builtIn parameter from DbFunctionAttribute
  • Make IndexAttribute.PropertyNames an IReadOnlyList
  • Change IndexAttribute.GetIsUnique to IsUniqueHasValue

Part of #20409

* Use FullName instead of DisplayName in the in-memory database
* Remove builtIn parameter from DbFunctionAttribute
* Make IndexAttribute.PropertyNames an IReadOnlyList
* Change IndexAttribute.GetIsUnique to IsUniqueHasValue
@ajcvickers ajcvickers requested a review from a team August 12, 2020 19:22
@ghost
Copy link

ghost commented Aug 12, 2020

Hello @ajcvickers!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 33ad238 into main Aug 12, 2020
@ghost ghost deleted the JustShutUpAndListenAyo0812 branch August 12, 2020 20:32
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants