ToQueryString for ReadItemQueryingEnumerable #22091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @ajcvickers! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
...mos/Query/Internal/CosmosShapedQueryCompilingExpressionVisitor.ReadItemQueryingEnumerable.cs
Outdated
Show resolved
Hide resolved
ajcvickers
force-pushed
the
NoOneWillNotice0816
branch
from
a06de50
to
0334a23
Compare
|
@dotnet/efcore Also added split-query ToQueryString message addendum, as discussed in triage. |
smitpatel
reviewed
Aug 17, 2020
test/EFCore.SqlServer.FunctionalTests/Query/NorthwindIncludeQuerySqlServerTest.cs
Show resolved
Hide resolved
smitpatel
reviewed
Aug 17, 2020
test/EFCore.SqlServer.FunctionalTests/Query/NorthwindSplitIncludeQuerySqlServerTest.cs
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Aug 17, 2020
ajcvickers
force-pushed
the
NoOneWillNotice0816
branch
from
0334a23
to
e0f2d8f
Compare
Also added message for split query, as discussed in triage.
Fix issue trying to execute non-executable SQL
ajcvickers
force-pushed
the
NoOneWillNotice0816
branch
from
e0f2d8f
to
d420744
Compare
ghost
merged commit
smitpatel
reviewed
Aug 18, 2020
| public override Task Include_collection_with_last_no_orderby(bool async) | ||
| { | ||
| return AssertTranslationFailedWithDetails( | ||
| () => AssertLast( |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20653