RevEng: Use pluralizer with database names too #22145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Aug 20, 2020
bricelam
commented
Aug 20, 2020
Comment on lines
+162
to
+171
| for (i = commonPrefix.Length - 3; i >= 0; i--) | ||
| { | ||
| if (char.IsLetterOrDigit(commonPrefix[i])) | ||
| { | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| return i != 0 | ||
| ? commonPrefix.Substring(0, i + 1) |
There was a problem hiding this comment.
Added this to strip trailing _, -, and whitespace. Matches what the C# namer would do.
smitpatel
approved these changes
Aug 20, 2020
|
Hello @bricelam! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12102