Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup for Relational #22183

Merged
merged 1 commit into from
Aug 23, 2020
Merged

Conversation

ajcvickers
Copy link
Member

No description provided.

@ajcvickers ajcvickers requested a review from a team August 23, 2020 18:07
@ajcvickers
Copy link
Member Author

@dotnet/efteam Anyone do a quick review of this so I can get all the code cleanup into 5.0 and main ready for tomorrow?

@ajcvickers ajcvickers merged commit 18f47ea into release/5.0 Aug 23, 2020
@ajcvickers ajcvickers deleted the DeepClean_Relational_1_0823 branch August 23, 2020 22:06
CancellationToken cancellationToken = default)
=> new ValueTask<InterceptionResult<DbTransaction>>(result);

/// <summary>
/// <para>
/// Called immediately after EF calls
/// <see cref="M:System.Data.Common.DbConnection.BeginTransactionAsync(System.Data.IsolationLevel,System.Threading.CancellationToken)" />.
/// <see cref="M:System.Data.Common.DbConnection.BeginTransactionAsync(System.Data.IsolationLevel,System.Threading.CancellationToken)" />
/// .

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why dot in next line?

@@ -109,7 +109,8 @@ public interface IDbTransactionInterceptor : IInterceptor
/// <summary>
/// <para>
/// Called immediately after EF calls
/// <see cref="M:System.Data.Common.DbConnection.BeginTransactionAsync(System.Data.IsolationLevel,System.Threading.CancellationToken)" />.
/// <see cref="M:System.Data.Common.DbConnection.BeginTransactionAsync(System.Data.IsolationLevel,System.Threading.CancellationToken)" />
/// .

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why dot in next line?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants