Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup for database providers #22185

Merged
1 commit merged into from
Aug 23, 2020
Merged

Conversation

ajcvickers
Copy link
Member

No description provided.

@ajcvickers ajcvickers requested a review from a team August 23, 2020 18:52
@@ -112,7 +112,7 @@ public static IReadOnlyList<T> HasNoNulls<T>(IReadOnlyList<T> value, [InvokerPar
}

[Conditional("DEBUG")]
public static void DebugAssert([CA.DoesNotReturnIf(false)] bool condition, string message)
public static void DebugAssert([CA.DoesNotReturnIfAttribute(false)] bool condition, string message)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More verbose than needed

@ghost
Copy link

ghost commented Aug 23, 2020

Hello @ajcvickers!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 659ebed into release/5.0 Aug 23, 2020
@ghost ghost deleted the DeepClean_Providers_1_0823 branch August 23, 2020 20:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants