Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Pushdown into subquery when applying over Skip after Distinct … #22249

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

smitpatel
Copy link
Member

…without order by

Since we add OrderBy(Select 1) for skip, Distinct needs to have ordering column in the projection

Resolves #8523

…without order by

Since we add OrderBy(Select 1) for skip, Distinct needs to have ordering column in the projection

Resolves #8523
@smitpatel smitpatel requested a review from a team August 26, 2020 17:44
@smitpatel
Copy link
Member Author

@Pilchie for RC1 approval

@Pilchie
Copy link
Member

Pilchie commented Aug 26, 2020

Approved for RC1.

@smitpatel smitpatel merged commit a92d732 into release/5.0 Aug 26, 2020
@smitpatel smitpatel deleted the smit/issue8523 branch August 26, 2020 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Query: incorrect sql generated for queries with Distinct Skip, FirstOrDefault (without order by)
3 participants