Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue#12518 #22257

Merged
1 commit merged into from
Aug 27, 2020
Merged

Fix issue#12518 #22257

1 commit merged into from
Aug 27, 2020

Conversation

smitpatel
Copy link
Member

Regression test already existed.
Added another variation for #22256

Close #12518

@ghost
Copy link

ghost commented Aug 26, 2020

Hello @smitpatel!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Regression test already existed.
Added another variation for #22256

Close #12518
@smitpatel
Copy link
Member Author

@msftbot merge only if it has Servicing-approved label

@smitpatel
Copy link
Member Author

@msftbot - merge only if it has Servicing-approved label

@ghost
Copy link

ghost commented Aug 27, 2020

Hello @smitpatel!

I think you told me that you expect someone to approve this pull request before I perform the merge, but I am not confident that I have understood you correctly.

Please try rephrasing your instruction to me.

@smitpatel
Copy link
Member Author

@msftbot - nevermind

@ghost
Copy link

ghost commented Aug 27, 2020

Hello @smitpatel!

Because you've told me to reset the custom auto-merge settings, I'll use the configured settings for this repository when I'm merging this pull request.

@ghost ghost merged commit cd75030 into release/5.0 Aug 27, 2020
@ghost ghost deleted the smit/issue12518 branch August 27, 2020 01:34
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NumberToBytesConverter on ulong RowVersion property fails with .Include query
2 participants