Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor model building perf improvements #22285

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Minor model building perf improvements #22285

merged 1 commit into from
Aug 28, 2020

Conversation

AndriySvyryd
Copy link
Member

No description provided.

@AndriySvyryd AndriySvyryd requested a review from a team August 28, 2020 02:16
@AndriySvyryd
Copy link
Member Author

@Pilchie For RC1

@Pilchie
Copy link
Member

Pilchie commented Aug 28, 2020

Approved for RC1.

@AndriySvyryd AndriySvyryd merged commit 8576f42 into release/5.0 Aug 28, 2020
@AndriySvyryd AndriySvyryd deleted the Issue20135 branch August 28, 2020 23:42
@ajcvickers ajcvickers mentioned this pull request Sep 10, 2020
Closed
@Saibamen
Copy link

Do you have any before/after benchmarks?

@AndriySvyryd
Copy link
Member Author

@Saibamen Sorry, I didn't save them or the model I was using. It was around 1-2% for a model with over 1500 entity types

#22314 was actually the big win with around 10% improvement

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
Servicing-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AndriySvyryd @Pilchie @Saibamen @smitpatel