Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to SQLitePCLRaw 2.0.4 #22297

Merged
1 commit merged into from
Sep 4, 2020
Merged

Update to SQLitePCLRaw 2.0.4 #22297

1 commit merged into from
Sep 4, 2020

Conversation

bricelam
Copy link
Contributor

@bricelam bricelam commented Aug 28, 2020

/cc @ericsink @Pilchie

Resolves #22198

@bricelam bricelam requested a review from a team August 28, 2020 16:57
@Pilchie
Copy link
Member

Pilchie commented Aug 28, 2020

How confident are we that a non-prerelease version will be out in time for us to adopt it? We can't ship 5.0 final with a pre-release dependency.

@ericsink
Copy link

"How confident are we"

Very confident.

@Pilchie
Copy link
Member

Pilchie commented Aug 28, 2020

Should we just wait for that then?

@ericsink
Copy link

I'll decline to give any advice on your process. :-) But for additional background:

The main purpose of this 2.0.4-pre is to let @bricelam verify that certain changes in my 2.0.4 work are working as expected. If he gives the thumbs-up on this -pre, I expect to do 2.0.4 final next week. If he finds a problem, I still expect to be able to fix it and do 2.0.4 final next week. I suspect that this PR is simply Brice's most convenient way to do the verification I just mentioned.

@bricelam
Copy link
Contributor Author

LGTM. Just a few test issues to fix. No product issues found. The new bundle_sqlite3 works like a charm on our macOS and Linux (Ubuntu) agents. We can wait for the final 2.0.4 release. I'll get this PR passing and we can just update it when the package is available.

@Pilchie
Copy link
Member

Pilchie commented Aug 28, 2020

Sounds great. Thanks @bricelam

@bricelam bricelam changed the title Update to SQLitePCLRaw 2.0.4-pre20200828111558 Update to SQLitePCLRaw 2.0.4 Sep 1, 2020
@bricelam bricelam changed the base branch from release/5.0 to release/5.0-rc2 September 3, 2020 18:22
@bricelam bricelam removed the blocked label Sep 3, 2020
@bricelam bricelam changed the base branch from release/5.0-rc2 to main September 3, 2020 18:25
@bricelam bricelam changed the base branch from main to release/5.0-rc2 September 3, 2020 18:25
@ghost
Copy link

ghost commented Sep 3, 2020

Hello @bricelam!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update 5.0 dependencies
4 participants