Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DbFunctions non-evaluatable #22318

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Make DbFunctions non-evaluatable #22318

merged 2 commits into from
Aug 31, 2020

Conversation

roji
Copy link
Member

@roji roji commented Aug 29, 2020

Fixes #22317

/cc @maumar who's looking at adding test coverage for collations

@roji roji requested a review from a team August 29, 2020 18:50
@smitpatel
Copy link
Member

Also apply same for all other provider specific functions.

@roji roji requested a review from smitpatel August 30, 2020 16:48
@roji roji changed the title Make Collate and Like non-evaluatable Make DbFunctions non-evaluatable Aug 30, 2020
@roji
Copy link
Member Author

roji commented Aug 30, 2020

@Pilchie for RC1 approval

@Pilchie
Copy link
Member

Pilchie commented Aug 31, 2020

Approved for RC1.

@roji roji merged commit e1fc483 into release/5.0 Aug 31, 2020
@roji roji deleted the CollateLikeEvaluatable branch August 31, 2020 17:44
@ajcvickers ajcvickers mentioned this pull request Sep 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
Servicing-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't use Collate or Like over constants
3 participants
@roji @smitpatel @Pilchie