Exception message update #22321
Merged
Exception message update #22321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Aug 30, 2020
|
@Pilchie RC1 |
This PR contains the specific changes we made in the meeting, plus using ``{entityType}.{property/navigation}' in EFCore consistently.
The tt files has been updated to allow moving of parameters without changing the method signature and hence without needing to update all call sites, which is error prone.
I have also added other changes we discussed as check boxes in #7201 so that we can track this like we do API reviews.
ajcvickers
force-pushed
the
TheSameWordsInADifferentWay0829
branch
from
d273a6e
to
11394a2
Compare
|
Approved for RC1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7201
This PR contains the specific changes we made in the meeting, plus using
'{entityType}.{property/navigation}'in EFCore consistently.The T4 file has been updated to allow moving of parameters without changing the method signature and hence without needing to update all call sites, which is errorprone.
I have also added other changes we discussed as check boxes in #7201 so that we can track this like we do API reviews.