Propagate MaxLength, Precision, Scale and IsUnicode to sharing columns #22396
Conversation
|
@Pilchie For RC2 |
|
Approved for .NET 5 RC2. |
| /// <param name="property"> The property. </param> | ||
| /// <param name="storeObject"> The identifier of the table-like store object containing the column. </param> | ||
| /// <returns> The maximum length, or <see langword="null" /> if none if defined. </returns> | ||
| public static int? GetMaxLength([NotNull] this IProperty property, in StoreObjectIdentifier storeObject) |
There was a problem hiding this comment.
@AndriySvyryd @smitpatel @ajcvickers Honestly I'm not surprised that so many bugs and regressions creep into EF Core with every release. This PR changes a whole bunch of code with only 1 small test added. These are new public APIs and are completely untested. Please, this needs to change 😞
There was a problem hiding this comment.
@Neme12 The test exercises and validates all the added code. But you have a point, we can certainly spend more time writing tests instead of adding more features. However our efforts would still fall short of the real-world scenarios that you and other early adopters run with the preview versions.
Thank you for your patience and diligence in reporting the issues!
Fixes #22387