Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grammar/style pass for CoreStrings #22417

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Grammar/style pass for CoreStrings #22417

merged 1 commit into from
Sep 8, 2020

Conversation

roji
Copy link
Member

@roji roji commented Sep 5, 2020

Part of #7201

@roji roji requested a review from a team September 5, 2020 16:47
@smitpatel
Copy link
Member

You need to run the template to regenerate the file.

@roji roji force-pushed the CoreStrings branch 2 times, most recently from 0ee9084 to e628246 Compare September 6, 2020 18:24
bricelam
bricelam reviewed Sep 8, 2020
View reviewed changes
Copy link
Contributor

@bricelam bricelam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndriySvyryd
Copy link
Member

@Pilchie FYI

@roji roji merged commit 7db82b4 into release/5.0-rc2 Sep 8, 2020
@roji roji deleted the CoreStrings branch September 8, 2020 19:08
@ajcvickers ajcvickers mentioned this pull request Sep 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricelam bricelam bricelam approved these changes

Assignees
No one assigned
Labels
Servicing-approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@roji @smitpatel @AndriySvyryd @bricelam @Pilchie