[release/3.1] Query: Unwind nested invocation expressions #22472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves #19511 Issue: When we unwound the first level, we did not visit it recursively.
Closed
ajcvickers
approved these changes
Sep 10, 2020
|
@smitpatel Approved for 3.1.9. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #19511
Port of #19514
Description
In 2.x query pipeline when we used Remotion.Linq library to normalize expression tree into query model, it also inlined all invocation expressions. In 3.1 we added code in our pipeline to do inilining but it was not applying it recursively.
Customer Impact
Customers using nested invocations to build expression tree get an exception with translation error.
How found
Customers reported that they are facing issue with invocation expressions even after the fix we added in 3.1.
Test coverage
Regression test added to verify that we cover recursive case.
Regression?
Yes, from EF Core 2.x to 3.1 as 2.x pipeline normalized this through external library.
Risk
Very low. Visiting recursively should be no-op if not the case of invocation. Also this fix has been released in 5.0 preview1 and we haven't had any feedback of anything breaking.