Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception message review #22519

Merged
1 commit merged into from
Oct 20, 2020
Merged

Exception message review #22519

1 commit merged into from
Oct 20, 2020

Conversation

roji
Copy link
Member

@roji roji commented Sep 13, 2020

Part of #7201

smitpatel
smitpatel previously requested changes Sep 14, 2020
View reviewed changes
Copy link
Member

@smitpatel smitpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Odd number of files :trollface:

@roji
Copy link
Member Author

roji commented Sep 14, 2020

The problem is me having to boot to Windows for VS to generate the file... That is just too much pain to handle in the same session as doing the review itself...

@smitpatel smitpatel requested a review from a team September 14, 2020 16:07
@smitpatel
Copy link
Member

As per @Pilchie's message in teams, can you retarget this to main?

@roji
Copy link
Member Author

roji commented Sep 14, 2020

Will do soon, and also resolve conflicts with your PR.

@bricelam bricelam changed the base branch from release/5.0-rc2 to main September 18, 2020 23:52
@roji roji mentioned this pull request Oct 15, 2020
Closed
@roji
Copy link
Member Author

roji commented Oct 17, 2020

Rebased, is ready for review.

This was referenced Oct 18, 2020
Closed
Open
@ghost
Copy link

ghost commented Oct 19, 2020

Hello @roji!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@AndriySvyryd
Copy link
Member

@smitpatel needs to approve to make the bot happy

@smitpatel
Copy link
Member

Or dismiss the review and avoid re-reviewing 😉

@smitpatel
Copy link
Member

@msftbot merge this PR after 1 min

@ghost
Copy link

ghost commented Oct 20, 2020

Hello @smitpatel!

Because you've given me some instructions on how to help merge this pull request, I'll be modifying my merge approach. Here's how I understand your requirements for merging this pull request:

  • I won't merge this pull request until after the UTC date Tue, 20 Oct 2020 02:49:20 GMT, which is in 1 minute

If this doesn't seem right to you, you can tell me to cancel these instructions and use the auto-merge policy that has been configured for this repository. Try telling me "forget everything I just told you".

@ghost ghost merged commit 5ff9243 into main Oct 20, 2020
@ghost ghost deleted the MoarStrings branch October 20, 2020 02:49
@roji
Copy link
Member Author

roji commented Oct 20, 2020

Or dismiss the review and avoid re-reviewing wink

The bot is more mysterious than I thought!

@ajcvickers ajcvickers mentioned this pull request Oct 22, 2020
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndriySvyryd AndriySvyryd AndriySvyryd approved these changes

@smitpatel smitpatel smitpatel left review comments

Assignees
No one assigned
Labels
auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roji @smitpatel @AndriySvyryd