Generate values for PK properties that are also self-referencing FK properties #22585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Sep 17, 2020
AndriySvyryd
requested changes
Sep 17, 2020
ajcvickers
force-pushed
the
GraphPaperCuts0917
branch
from
96d013d
to
7119917
Compare
|
@AndriySvyryd Already made that change based on previous comment. Just pushed. |
AndriySvyryd
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22573
Description
This is a regression from preview 8 on a very common case for a major new feature. We added FK constraints to the TPT model in RC1, but this broke value generation for the PK property of any TPT mapping.
Customer Impact
Very common scenario on a major new feature.
How found
Customer reported moving from preview 8 to RC1.
Test coverage
We were lacking test coverage for change tracking in TPT models. This PR adds a TPT variation to our main change tracking tests (1622 tests). This revealed one additional bug which we will triage separately.
Regression?
New feature in 5.0, but regression from preview 8.
Risk
Low. Issue is well understood and fix is small.