[5.0-rc2] Throw exception for cycles in auto included navigations #22612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #22568
Description
It is possible to have bad configuration of auto included navigations in the model which causes a cycle.
Customer Impact
Customers with bad configuration when running a query with affected types runs into stackoverflow indicating no information about the error.
How found
Customer reported on RC1.
Test coverage
It is a negative case scenario. We did not have coverage for it. We have added coverage for supported scenario with cycle and error validation for incorrect case.
Regression?
No, it is new feature introduced in 5.0
Risk
Low. It should only affect when auto includes are used. Further any error can be mitigated by ignoring auto include at query level.