Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/3.1] Include commit SHA in [AssemblyInformationalVersion] value #22650

Merged
merged 1 commit into from
Oct 13, 2020
Merged

[release/3.1] Include commit SHA in [AssemblyInformationalVersion] value #22650

merged 1 commit into from
Oct 13, 2020

Conversation

dougbu
Copy link
Member

@dougbu dougbu commented Sep 21, 2020

@dougbu dougbu added this to the 3.1.10 milestone Sep 21, 2020
@dougbu dougbu requested a review from a team September 21, 2020 23:32
@dougbu
Copy link
Member Author

dougbu commented Sep 21, 2020

@ajcvickers @Pilchie I created a new 3.1.10 milestone and put this PR into it. That is, this is a tell-mode change targeting the next 3.1 release; not rushing.

@dougbu dougbu mentioned this pull request Sep 22, 2020
Merged
@ajcvickers
Copy link
Member

This should not be merged until we have resolved the situation on #22649

@dougbu
Include commit SHA in [AssemblyInformationalVersion] value (#22649)
a41d020 
* Add `[AssemblyMetadata("CommitHash", ...)]` to all C# assemblies
- see dotnet/arcade#5866 discussion
- provide the commit SHA though not in usual `[AssemblyInformationalVersion]` format

* Include `[AssemblyMetadata("Serviceable", "true")]` too
- see dotnet/arcade#1526
@dougbu
Copy link
Member Author

dougbu commented Sep 24, 2020

This should not be merged until we have resolved the situation on #22649

That's been resolved but this PR still has to wait for branches to open

@wtgodbe wtgodbe merged commit b0bf719 into release/3.1 Oct 13, 2020
@wtgodbe wtgodbe deleted the dougbu/include.SHA.3.1 branch October 13, 2020 20:07
@ajcvickers ajcvickers mentioned this pull request Oct 22, 2020
Closed
@ajcvickers ajcvickers removed this from the 3.1.10 milestone Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bricelam bricelam bricelam approved these changes

@wtgodbe wtgodbe wtgodbe approved these changes

Assignees
No one assigned
Labels
area-infrastructure tell-mode
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dougbu @ajcvickers @bricelam @wtgodbe