Disable auto-generating symbols.nupkgs #22861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmitche
reviewed
Oct 1, 2020
mmitche
approved these changes
Oct 1, 2020
|
Not sure who can merge this, @smitpatel ? @mmitche ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/core-eng/issues/11032 which was discovered by post build signing. Arcade was auto-generating some symbols.nupkgs in this repo, but this repo wasn't expecting them and didn't include them in the asset manifest. The result was that post build signing validation would discover some symbols.nupkgs that it wasn't told to sign and validation would fail.