[release/5.0] Ensure grandchildren and below are mapped to the root table when using table sharing. #22875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
approved these changes
Oct 3, 2020
…g table sharing. Fixes #22873
AndriySvyryd
force-pushed
the
Issue22873
branch
from
913c5f2
to
bc5919d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22873
Description
When a hierarchy with more than 2 levels is mapped using TPT and the root table has other types sharing it the relational model didn't include all the derived types in the mapping.
Customer Impact
Queries and updates fail for the affected models. There is no reasonable workaround.
How found
Customer report on daily build.
Test coverage
This PR adds tests for the affected scenario.
Regression?
No.
Risk
Low. The change only affects a new 5.0 feature TPT.