[5.0] Fix places where skip navigations are missed #22884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
force-pushed
the
ThemNavsTooBertrum1004
branch
from
7f1a852
to
4d81e6a
Compare
Fixes #22882 **Description** Skip navigations (i.e. many-to-many navigations; new for 5.0) are not being returned as members, navigations, or collections from an an API used to access them. In addition, scrubbing the code found three other issues with the same pattern, plus a few that need more investigation. This PR contains fixes and tests for the four clear issues. I have filed #22883 to follow up on the others. **Customer Impact** * Navigations for a major new feature are not being returned from an API that should return them. * Attaching a graph asynchronously may miss navigations. * Skip navigations are missed as notification properties. * Exception will say a property is not found, when actually it is a navigation. **How found** Customer reported on RC2 daily build. **Test coverage** This PR adds tests for the affected cases, including others found from scrubbing the code. #22883 tracks doing more research in this area. **Regression?** No. **Risk** Low. The change only affects skip navigations, which are new in 5.0.
ajcvickers
force-pushed
the
ThemNavsTooBertrum1004
branch
from
4d81e6a
to
59a5ef6
Compare
AndriySvyryd
approved these changes
Oct 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22882
Description
Skip navigations (i.e. many-to-many navigations; new for 5.0) are not being returned as members, navigations, or collections from an an API used to access them. In addition, scrubbing the code found three other issues with the same pattern, plus a few that need more investigation. This PR contains fixes and tests for the four clear issues. I have filed #22883 to follow up on the others.
Customer Impact
How found
Customer reported on RC2 daily build.
Test coverage
This PR adds tests for the affected cases, including others found from scrubbing the code. #22883 tracks doing more research in this area.
Regression?
No.
Risk
Low. The change only affects skip navigations, which are new in 5.0.