[5.0] Add validation for seed data with skip navigations #22908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
approved these changes
Oct 6, 2020
|
@ajcvickers Ok to push with errors due to infrastructure? |
|
@AndriySvyryd What are the infrastructure issues? Do we know if they are being worked on? /cc @dotnet/aspnet-build |
|
@AndriySvyryd Those links indicate that the issue has been fully mitigated. Maybe we can re-try one more time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #22883
Description
Skip navigations (i.e. many-to-many navigations; new for 5.0) could contain entities when used in seed data. However they will be ignored.
Customer Impact
With this change EF will throw an exception explaining the supported way to add seed data. Making this change after 5.0 would be a bigger breaking change as more users could be affected.
How found
Code examination.
Test coverage
This PR adds tests for the affected case.
Regression?
No.
Risk
Low. The change only affects skip navigations, which are new in 5.0.