Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed potential torn reads in EventCounters #22923

Merged
merged 4 commits into from
Oct 9, 2020
Merged

Fixed potential torn reads in EventCounters #22923

merged 4 commits into from
Oct 9, 2020

Commits on Oct 8, 2020

  1. Fixed potential torn reads in EventCounters 

    The backing fields for the counters are `long`, so there was potential torn read on 32-bit platforms.
`Volatile.Read` ensures that the value is read in a atomic way, so no torn reads can occur.
    @gfoidl
    gfoidl committed Oct 8, 2020
    Configuration menu
    Copy the full SHA
    2182ac3 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2020

  1. Use Interlocked.Read instead of Volatile.Read

    @gfoidl
    gfoidl committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    cd273d8 View commit details
    Browse the repository at this point in the history

  2. Fixed the build-break 

    Too eagerly with find & replace -- sorry.
    @gfoidl
    gfoidl committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    2038844 View commit details
    Browse the repository at this point in the history

  3. Updated CacheInfo.CalculateAndReset to use Interlocked.Exchange

    @gfoidl
    gfoidl committed Oct 9, 2020
    Configuration menu
    Copy the full SHA
    2d39eb9 View commit details
    Browse the repository at this point in the history