Work around mono bug affecting Xamarin Android (#22982) #22995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Oct 14, 2020
|
Tactics approved the |
|
Merged, sorry for the double PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR merged to main: #22982
Fixes #22665
(cherry picked from commit fbc11f2)
Description
A mono bug currently prevents EF Core 5.0 from being used on Xamarin Android (and possibly other mono-based platforms). This PR replaces the API call causing issues on mono with a workaround that does not.
Customer Impact
EF Core 5.0 is currently unusable with Xamarin Android.
How found
Reported by a user: #22665
Test coverage
We unfortunately do not have test coverage for Xamarin yet (#8792). We do have testing around this code area which confirms the fix doesn't introduce other regressions in general.
Regression?
Yes, from 3.1.x
Risk
Low, the change is a very local replacement of a single API call with another code pattern that does the same thing.