Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify string.IsNullOrEmpty translation for SqlServer #23039

Merged
merged 1 commit into from
Oct 18, 2020
Merged

Simplify string.IsNullOrEmpty translation for SqlServer #23039

merged 1 commit into from
Oct 18, 2020

Conversation

Marusyk
Copy link
Member

@Marusyk Marusyk commented Oct 18, 2020

Extends SqlServerStringMethodTranslator (without changes in StringMethodTranslator) to simplify string.IsNullOrEmpty translation

@value IS NULL OR @value LIKE N''

instead of

@value IS NULL OR @value = N''

Fixes #23037

Please review
Thank you in advance

roji
roji approved these changes Oct 18, 2020
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@roji
Copy link
Member

roji commented Oct 18, 2020

Unrelated build failures (dotnet-install failing on macos), merging.

@roji roji merged commit 6b67689 into dotnet:main Oct 18, 2020
@Marusyk Marusyk deleted the rmarusyk/23037 branch October 18, 2020 15:04
@ajcvickers ajcvickers mentioned this pull request Oct 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
community-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SqlServer: Translate string.IsNullOrEmpty with LIKE
3 participants
@Marusyk @roji @ajcvickers