Improve exception messages #23080
Merged
Improve exception messages #23080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Oct 23, 2020
| @@ -623,7 +623,10 @@ | |||
| <value>No value was provided for the required parameter '{parameter}'.</value> | |||
| </data> | |||
| <data name="ModificationCommandInvalidEntityState" xml:space="preserve"> | |||
| <value>Cannot save changes for an entity in state '{entityState}'.</value> | |||
| <value>Cannot save changes for an entity of type '{entityType} in state '{entityState}'. This may indicate a bug in Entity Framework, please report it. Consider using 'DbContextOptionsBuilder.EnableSensitiveDataLogging' to see the key values of the entity.</value> | |||
There was a problem hiding this comment.
Suggested change
| <value>Cannot save changes for an entity of type '{entityType} in state '{entityState}'. This may indicate a bug in Entity Framework, please report it. Consider using 'DbContextOptionsBuilder.EnableSensitiveDataLogging' to see the key values of the entity.</value> | |
| <value>Cannot save changes for an entity of type '{entityType}' in state '{entityState}'. This may indicate a bug in Entity Framework, please report it. Consider using 'DbContextOptionsBuilder.EnableSensitiveDataLogging' to see the key values of the entity.</value> |
I think we have a fwlink for please report it some other exception messages. We should copy that.
There was a problem hiding this comment.
I though we did, but I cannot find it.
There was a problem hiding this comment.
efcore/src/EFCore/Properties/CoreStrings.resx
Lines 190 to 192 in 5ff9243
src/EFCore.SqlServer/Update/Internal/SqlServerModificationCommandBatch.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
force-pushed
the
Issue7201
branch
2 times, most recently
from
0b3bb01
to
d42f304
Compare
smitpatel
approved these changes
Oct 23, 2020
AndriySvyryd
force-pushed
the
Issue7201
branch
from
d42f304
to
1f3d520
Compare
|
Hello @AndriySvyryd! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
Part of #7201
AndriySvyryd
force-pushed
the
Issue7201
branch
from
1f3d520
to
17510f5
Compare
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7201