[5.0.1] Fix issues with property called FooId on base type Foo in TPT #23112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet/efteam In the past we would have quirked this for safety. Should we continue to do that by default going forward? |
|
@ajcvickers Yes, but I want to do it in a separate commit to make the merging to main easier |
smitpatel
reviewed
Oct 28, 2020
src/EFCore.SqlServer/Metadata/Conventions/SqlServerIndexConvention.cs
Outdated
Show resolved
Hide resolved
smitpatel
reviewed
Oct 28, 2020
src/EFCore/Metadata/Conventions/ForeignKeyPropertyDiscoveryConvention.cs
Show resolved
Hide resolved
AndriySvyryd
force-pushed
the
Issue23092
branch
from
5693c95
to
00a9a72
Compare
smitpatel
approved these changes
Oct 29, 2020
|
Approved by Tactics for 5.0.1. |
Silently ignore inherited properties in TPT in SqlServerIndexConvention Fixes #23092
AndriySvyryd
force-pushed
the
Issue23092
branch
from
00a9a72
to
05d1ddd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23092
Description
The fix does the following:
SqlServerIndexConventioninstead of throwing an exceptionCustomer Impact
Currently when there's property with name in form of FooId on base type named Foo in a TPT hierarchy an exception is thrown when a convention is applied. The workaround is non-obvious and might not work when there are multiple types with this pattern.
How found
Reported by user on RC2
Test coverage
This PR includes tests for the affected scenario.
Regression?
No, this only affects TPT - a new feature in 5.0
Risk
Low. The fix only affects models using TPT.