Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cosmos: Instance can be null for member translation #23204

Merged
1 commit merged into from
Nov 5, 2020
Merged

Cosmos: Instance can be null for member translation #23204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/EFCore.Cosmos/Query/Internal/CosmosMemberTranslatorProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,11 @@ public CosmosMemberTranslatorProvider(
/// doing so can result in application failures when updating to a new Entity Framework Core release.
/// </summary>
public virtual SqlExpression? Translate(
SqlExpression instance,
SqlExpression? instance,
MemberInfo member,
Type returnType,
IDiagnosticsLogger<DbLoggerCategory.Query> logger)
{
Check.NotNull(instance, nameof(instance));
Check.NotNull(member, nameof(member));
Check.NotNull(returnType, nameof(returnType));
Check.NotNull(logger, nameof(logger));
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Cosmos/Query/Internal/IMemberTranslator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public interface IMemberTranslator
/// doing so can result in application failures when updating to a new Entity Framework Core release.
/// </summary>
SqlExpression? Translate(
[NotNull] SqlExpression instance,
[CanBeNull] SqlExpression? instance,
[NotNull] MemberInfo member,
[NotNull] Type returnType,
[NotNull] IDiagnosticsLogger<DbLoggerCategory.Query> logger);
Expand Down
2 changes: 1 addition & 1 deletion src/EFCore.Cosmos/Query/Internal/IMemberTranslatorProvider.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public interface IMemberTranslatorProvider
/// doing so can result in application failures when updating to a new Entity Framework Core release.
/// </summary>
SqlExpression? Translate(
[NotNull] SqlExpression instance,
[CanBeNull] SqlExpression? instance,
[NotNull] MemberInfo member,
[NotNull] Type returnType,
[NotNull] IDiagnosticsLogger<DbLoggerCategory.Query> logger);
Expand Down