[5.0.1] Sqlite Migrations: Handle Z and M in spatial columns #23298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndriySvyryd
approved these changes
Nov 13, 2020
bricelam
changed the title
|
Approved by Tactics for 5.0.1. |
ajcvickers
added
Servicing-approved
and removed
Servicing-consider
sent-to-tactics
labels
|
Note to self: Create a new issue for the specific bug fixed by this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23390
Description
We took some fixes in EF Core 5.0 to enable using additional dimensions (Z and M) in spatial data on SQLite. However, we missed some updates in Migrations resulting in the columns getting created incorrectly in the database.
Customer Impact
This only affects users wanting to start using Z and M in EF Core 5.0. The columns are created in a way that can read and write the data, but more advanced queries and database validation of the data won't work.
How found
Customer reported
Test coverage
We have coverage of reading and writing these values to the database, but no coverage asserting the DML we use to create the columns. This PR adds that coverage.
Regression?
No, Z and M did not work at all in SQLite prior to EF Core 5.0.
Risk
Low