[5.0.1] Use topological sort to detect identifying relationship cycles. #23320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
reviewed
Nov 13, 2020
smitpatel
approved these changes
Nov 13, 2020
ajcvickers
added
sent-to-tactics
Servicing-approved
and removed
Servicing-consider
sent-to-tactics
labels
|
Approved by Tactics for 5.0.1. |
AndriySvyryd
force-pushed
the
Issue23289
branch
from
6c15f92
to
593d967
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23289
Description
EF Core 5.0 adds validation that detects identifying relationship cycles to prevent infinite recursion. However the algorithm used returned false positive for multiple paths.
Customer Impact
Users who have identifying relationships with multiple paths in their model are unable to use them.
How found
User-reported for 5.0.0
Test coverage
Added in this PR.
Regression?
Yes, the affected scenario worked correctly in 3.1
Risk
Low. The topological sort implementation has been in use since 1.0 and is thoroughly tested.