[5.0.1] Query: Match types in conditional during client evaluation #23323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
changed the title
maumar
approved these changes
Nov 13, 2020
ajcvickers
added
sent-to-tactics
Servicing-approved
and removed
Servicing-consider
sent-to-tactics
labels
|
Approved by Tactics for 5.0.1. |
smitpatel
force-pushed
the
smit/types
branch
from
5143643
to
03f151b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #23309
Description
Regression when client evaluation in the final projection (common) encounters a conditional expression where one part can be null in the database. In this case we end up with mismatched types between the true/false part of the conditional, resulting in an exception.
Customer Impact
Regression when a ternary is used in projection when client eval happens, which is a common case.
How found
Customer reported on 5.0.
Test coverage
Added test for affected scenario.
Regression?
Yes, from 3.1.
Risk
Low. Convert node would only fail when null is encountered when non-null expected which is error.