[5.0.1] Query: Add null check in hash computation in SqlFunctionExpression #23350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
approved these changes
Nov 16, 2020
|
@smitpatel You indicated that this is not a regression, but in the issue the customer says that it is a regression. Why is it appearing as a regression for them? |
|
The same null ref was this class was in 3.1 too. I haven't tested customer app. May be that code path was not triggered in 3.1 so could be a regression in that sense. |
smitpatel
changed the title
|
@ajcvickers - Updated. |
ajcvickers
added
sent-to-tactics
Servicing-approved
and removed
Servicing-consider
sent-to-tactics
labels
|
Approved by Tactics for 5.0.1. |
Resolves #23336 Add quirk
smitpatel
force-pushed
the
smit/nullcheck
branch
from
ec83081
to
142b5ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #23336
Description
Hash code computation in SqlFunctionExpression does not check for null for niladic functions (non-parameter functions). Niladic functions are frequent in Spatial types.
Customer Impact
Queries involving collection projection, spatial function and FirstOrDefault will throw null ref.
How found
Customer reported on 5.0.
Test coverage
Test added for affected scenario.
Regression?
Yes, the buggy code existed on 3.1 too but it was not being hit in some query scenario. Other changes in query exposed this bug and made working queries from 3.1 to fail in 5.0
Risk
Low.